Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation] add tags to item modules #2378

Merged
merged 2 commits into from
May 25, 2021
Merged

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented May 23, 2021

Tags are required to enable auto-mapping of inputs and outputs of modules in a rule, see openhab/openhab-addons#10205 (comment).

Also made command/state config params optional and being regarded, if they are set. This way it is avoided that auto-wiring prevents users from defining dedicated values in the actions.

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from a team May 23, 2021 22:27
@kaikreuzer kaikreuzer marked this pull request as draft May 24, 2021 06:57
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer marked this pull request as ready for review May 24, 2021 19:05
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Thus auto-mapping feature sounds really interesting. I do not know very much about it but like to learn. Do we have some documentation about it?

@cweitkamp cweitkamp added this to the 3.1 milestone May 25, 2021
@cweitkamp cweitkamp merged commit 0343f44 into openhab:main May 25, 2021
@kaikreuzer kaikreuzer deleted the moduletags branch May 25, 2021 19:33
@kaikreuzer
Copy link
Member Author

@cweitkamp The best documentation about auto-mapping can be found in its JavaDoc.
Note that it is a feature on top of "connections" between outputs and inputs. We don't use this feature in the Main UI yet - it would also be possible for the user to explicitly wire outputs and inputs together. The auto-mapping only deals with "what is left".

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
* add tags to item modules
* made state/command configuration optional

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 0343f44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants