[config] Changed 'ConfigDescriptionParameterDTO' field serialization 'defaultValue' -> 'default' #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault' Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
enhancement
cweitkamp
commented
May 25, 2021
| @@ -29,6 +30,7 @@ | |||
| public class ConfigDescriptionParameterDTO { | |||
|
|
|||
| public String context; | |||
| @SerializedName(value = "default") | |||
There was a problem hiding this comment.
As mentioned in #2376 (comment) we can use the following syntax to allow both names for parsing.
Suggested change
| @SerializedName(value = "default") | |
| @SerializedName(value = "default", alternate = "defaultValue") |
There was a problem hiding this comment.
Sounds like the safer option in any case. Shall we use this one? What is your preference?
There was a problem hiding this comment.
I'd prefer adding the fallback. We are backwards compatible against parsing then and can remove it after 3.1 has been released.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
kaikreuzer
approved these changes
May 29, 2021
ghys
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Jun 2, 2021
…alue' -> 'default' (#1077) Related to openhab/openhab-core#2383. Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/solar-plant-with-battery-widget/130502/8 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…'defaultValue' -> 'default' (openhab#2383) * Changed ConfigParameterDTO field serialization 'defaultValue' -> 'default' Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: 585e870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigDescriptionParameterDTOfield serialization: "defaultValue" -> "default"ConfigDescriptionDTOMapperfor field "unit"ConfigDescriptionDTOMapper,ConfigDescriptionResourceandAutomationIntegrationJsonTestSupersedes #2376
Related to #2148
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de