Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GALLON_LIQUID_US and GALLON_PER_MINUTE to UoM #2401

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

jsjames
Copy link
Contributor

@jsjames jsjames commented Jun 6, 2021

Corrected type for of SQUARE_FOOT and CUBIC_FOOT to be Unit and Unit, respectively

Added SQUARE_INCH, CUBIC_INCH, GALLON_LIQUID_US and GALLON_PER_MINUTE

@jsjames jsjames requested a review from a team as a code owner June 6, 2021 21:54
… Unit<Volume>, respectively

Added SQUARE_INCH, CUBIC_INCH, GALLON_LIQUID_US and GALLON_PER_MINUTE

Signed-off-by: Jeff James <jeff@james-online.com>
@cweitkamp cweitkamp added enhancement An enhancement or new feature of the Core UoM Units of Measurement labels Jun 7, 2021
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 3.1 milestone Jun 8, 2021
@cweitkamp cweitkamp merged commit c033741 into openhab:main Jun 8, 2021
@jsjames jsjames deleted the uom_imperial branch June 8, 2021 20:13
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
…MINUTE (openhab#2401)

Added SQUARE_INCH, CUBIC_INCH, GALLON_LIQUID_US and GALLON_PER_MINUTE
Corrected type for of SQUARE_FOOT and CUBIC_FOOT to be Unit<Area> and Unit<Volume>, respectively

Signed-off-by: Jeff James <jeff@james-online.com>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
…MINUTE (openhab#2401)

Added SQUARE_INCH, CUBIC_INCH, GALLON_LIQUID_US and GALLON_PER_MINUTE
Corrected type for of SQUARE_FOOT and CUBIC_FOOT to be Unit<Area> and Unit<Volume>, respectively

Signed-off-by: Jeff James <jeff@james-online.com>
GitOrigin-RevId: c033741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core UoM Units of Measurement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants