Enhanced sitemap SSE event with a new boolean field informing if the

[lolodomo]

item state or command description has been updated

Listen to the new ChannelDescriptionChangedEvent

Signed-off-by: Laurent Garnier lg.hc@free.fr

[lolodomo]

@cweitkamp @kaikreuzer : that would be really cool if you could do a very fast review & merge.

This is the core part of the changes necessary to trigger the handling of updated dynamic state/command description in any UI handling sitemaps.
I just added a new field in the SSE message. This will be with no impact on unmodified UI app.
I will then update Basic UI to read this new field and I will trigger a page reload when the field is set to true.

[lolodomo]

@mueller-ma @maniac103 : for your information in case you would like to handle that in the Android app.

[lolodomo]

@timbms : for iOS app (in case the iOS app is based on the sitemap SSE events)

[cweitkamp]

LGTM. Thanks.

[lolodomo]

Excellent, thank you. I will work on Basic UI enhancement today.

@kaikreuzer : Please trigger again a new core rebuild for next snapshots.

[maniac103]

@lolodomo Do apps need changing at all? I'd think the new description values should be part of the event sent out, shouldn't they?
(And BTW, handling this in the server is a very good idea, thank you for that!)

[lolodomo]

@lolodomo Do apps need changing at all? I'd think the new description values should be part of the event sent out, shouldn't they?

Yes, the new state description / command description is part of the sent event. If you are already updating the command/state options when receiving such an event, that is perfect and you have nothing more to do.
So I will test if it already works in Android app.
In BasicUI, it is not yet handled.

[lolodomo]

@maniac103 : excellent, I just tested the Android app and it works well. You have nothing to do ;)

@timbms : can you give us a feedback for the iOS app ? Something to change or not ?

[kaikreuzer]

@kaikreuzer : Please trigger again a new core rebuild for next snapshots.

@lolodomo Did so: https://ci.openhab.org/job/openHAB-Core/797/

I will work on Basic UI enhancement today.

Please note that we are officially now already in code freeze and I planned to do the RC1 build right now.

If you think the Basic UI changes are straight forward and riskless, I'd give you until 1pm and postpone the RC1 build until then. Otherwise, I'd suggest to live without those changes for 3.1.

[maniac103]

A bit OT:

Please note that we are officially now already in code freeze and I planned to do the RC1 build right now.

Does this also affect addons? I have one addition I'd really love to see in 3.1, but I'm not sure how to expedite code review there (or, for starters, getting this into the 3.1 milestone marker)

[lolodomo]

If you think the Basic UI changes are straight forward and riskless, I'd give you until 1pm and postpone the RC1 build until then.

I will try for 1pm French hour.

[kaikreuzer]

Does this also affect addons?

@maniac103 Yes, it does. But as it is just 1pm, I have merged it for you :-)

[lolodomo]

Too late for me, I encounter a difficulty to detect my new field, probably something stupid but I will find the solution only this evening.

[kaikreuzer]

Ok, then I will start the RC1 build now - nonetheless, thanks for trying!

[lolodomo]

@kaikreuzer : my PR is now submitted (just 4 lines of code).

[maniac103]

Yes, it does. But as it is just 1pm, I have merged it for you :-)

Great, thank you!