Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NSEE when there is no AddonService #2493

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Sep 23, 2021

The code was already prepared for a nullable default service and then returns a 404 not found.

Fixes #2491

@wborn wborn requested a review from a team as a code owner September 23, 2021 15:44
@wborn wborn changed the title Prevent NSEE when there is no addonService Prevent NSEE when there is no AddonService Sep 23, 2021
The code was already prepared for a nullable default service and then returns a 404 not found.

Fixes openhab#2491

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Sep 23, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 641b923 into openhab:main Sep 25, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Sep 25, 2021
@wborn wborn deleted the prevent-nsee branch September 25, 2021 19:05
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
The code was already prepared for a nullable default service and then returns a 404 not found.

Fixes openhab#2491

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 641b923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSuchElementException in AddonResource when trying to get default service in IDE
2 participants