Use the mime types provided by the ScriptEngineFactory #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derlying script engines they provide. This allows mutliple versions of script engines to co-exist, like Nashorn and GraalVM . Signed-off-by: Dan Cunningham <dan@digitaldan.com>
This was referenced Dec 8, 2021
cweitkamp
reviewed
Dec 9, 2021
...va/org/openhab/core/automation/module/script/internal/provider/ScriptModuleTypeProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Thanks @cweitkamp with the other PR's merged, this is the last one needed to have both runtime co-exist! |
3 tasks
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Use the mime types provided by the ScriptEngineFactory and not the underlying script engines they provide. This allows mutliple versions of script engines to co-exist, like Nashorn and GraalVM . Signed-off-by: Dan Cunningham <dan@digitaldan.com> GitOrigin-RevId: eb3f1e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the mime types provided by the ScriptEngineFactory and not the underlying script engines they provide. This allows mutliple versions of script engines to co-exist, like Nashorn and GraalVM .
Signed-off-by: Dan Cunningham dan@digitaldan.com