Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ZonedDateTime instead of Date in ModifiablePersistenceService interface #2660

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 2, 2022

…erface

If PRs are created to implement this interface, it would be better if we can prevent the propagation of old APIs like Date.

Related to:

* openhab/openhab-addons#11922
* openhab/openhab-addons#11923
* https://github.com/openhab/openhab-core/issues/2618#issuecomment-1003544762

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner January 2, 2022 15:12
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

This is a good idea 👍🏼 .

@cweitkamp cweitkamp merged commit 0bdaeef into openhab:main Jan 2, 2022
@cweitkamp cweitkamp added enhancement An enhancement or new feature of the Core persistence labels Jan 2, 2022
@cweitkamp cweitkamp added this to the 3.3 milestone Jan 2, 2022
@wborn wborn deleted the mps-zdt branch January 2, 2022 20:25
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
…nceService interface (openhab#2660)

If PRs are created to implement this interface, it would be better if we can prevent the propagation of old APIs like Date.

Related to:

* openhab/openhab-addons#11922
* openhab/openhab-addons#11923
* https://github.com/openhab/openhab-core/issues/2618#issuecomment-1003544762

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 0bdaeef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core persistence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants