Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[profiles] Do not log a warning if QuantityState has unit AbstractUnit.ONE #2662

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[profiles] Do not log a warning if QuantityState has unit AbstractUnit.ONE #2662

merged 1 commit into from
Jan 4, 2022

Conversation

cweitkamp
Copy link
Contributor

  • Do not log a warning if QuantityState has unit AbstractUnit.ONE

I added this check to deal with dimensionless QuantityTypes without unit (internally AbstractUnit.ONE) because for them it is not possible to define a unit in the compare condition as the unit symbol is an empty string.

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp
Do not log a warning if QuantityState has unit AbstractUnit.ONE
cc73584 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp requested a review from a team as a code owner January 3, 2022 15:37
kaikreuzer
kaikreuzer approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@kaikreuzer kaikreuzer merged commit 378aacb into openhab:main Jan 4, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone Jan 4, 2022
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Jan 4, 2022
@cweitkamp cweitkamp deleted the bugfix-unit-one-handling branch January 4, 2022 20:24
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@cweitkamp @splatch
Do not log a warning if QuantityState has unit AbstractUnit.ONE (open…
4a65b85 
…hab#2662)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
GitOrigin-RevId: 378aacb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@cweitkamp @kaikreuzer