Support multi bundle bindings in i18n-maven-plugin #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin did not generate translations for bundles of bindings that do not have a binding.xml file. With this change it should also be possible to generate the default translations of the modbus and mqtt bindings. Related to openhab/openhab-addons#12220 Signed-off-by: Wouter Born <github@maindrain.net>
cweitkamp
reviewed
Feb 14, 2022
| } else if (type instanceof ChannelTypeXmlResult) { | ||
| bundleInfo.getChannelTypesXml().add((ChannelTypeXmlResult) type); | ||
| ChannelTypeXmlResult result = (ChannelTypeXmlResult) type; | ||
| bundleInfo.getChannelTypesXml().add(result); |
There was a problem hiding this comment.
What about setting the bindingId here in the bundleInfo too?
There was a problem hiding this comment.
These kind of XML files don't have a bindingId attribute which is used in a UID. The parsed objects only have URIs which can be based on anything.
There was a problem hiding this comment.
I see the ChannelType does extend from AbstractDescriptionType that has a UID, so I'll check if I can add a bindingId based on that. 🙂
Signed-off-by: Wouter Born <github@maindrain.net>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Support multi bundle bindings in i18n-maven-plugin The plugin did not generate translations for bundles of bindings that do not have a binding.xml file. With this change it should also be possible to generate the default translations of the modbus and mqtt bindings. Related to openhab/openhab-addons#12220 Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: c300410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin did not generate translations for bundles of bindings that do not have a binding.xml file.
With this change it should also be possible to generate the default translations of the modbus and mqtt bindings.
Related to openhab/openhab-addons#12220