[rest] Allow binary MediaType for RawType item states #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-3-release-discussion/136925/10 |
|
Is there any documentation what file types are supported (e.g. in the swagger) or is the information only available in the source code? |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: ea68ae0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1581
This PR adds the ability to use different media types for RawType states. If the
Acceptheader does not specifytext/plain(which is the default used before), a new method checks if any of the provided media types in the header matches the media type of the state and sends the response with that media-type set. If no match is found, but theAcceptheader specifiesapplication/octet-streamthis media type is used. In case of media-type mismatch status 415 (unsupported media type) is returned. If the item state is notRawTypethe request is considered invalid and a 400 (bad request) is returned.Signed-off-by: Jan N. Klug github@klug.nrw