Fix things in REMOVING state initialize instead of getting removed #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
reviewed
Mar 14, 2022
...s/org.openhab.core.thing/src/main/java/org/openhab/core/thing/internal/ThingManagerImpl.java
Outdated
Show resolved
Hide resolved
…thing/internal/ThingManagerImpl.java Co-authored-by: Wouter Born <github@maindrain.net>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
…penhab#2828) Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 437b31d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves eclipse-archived/smarthome#942
If a thing changes its status to REMOVING when it is not initialized the thing cannot be removed because
handleRemovalcannot be called on an uninitialized handler. This is likely to happen when a binding is not available. When the binding becomes available again, theThingManagererroneously changed the thing status to INITIALIZING and the thing handler get's initialized and ONLINE later. This PR callsinitializeon the handler (sohandleRemovalcan be called later) but preserves the REMOVING status. When theThingHandlertries to change the status to ONLINE,handleRemovalis called and the thing finally removed.IMO #2517 should be closed if this is merged, as it is expected that either
handleRemovalis called or the thing is force removed.Signed-off-by: Jan N. Klug github@klug.nrw