Fix ScriptEngine not removed if created by ScriptAction #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Good catch, i'm pretty sure we have had reports of memory issues with UI rules that we have been unable to track down, this sounds like it could be one of the factors for that. |
|
Found it by chance when I tried to implement something to solve #2881 and tried to track the access to the cache objects. It worked nicely up to the point where the ScriptExtensionPRovider was never notified of the unloading of a script. |
wborn
pushed a commit
that referenced
this pull request
Apr 6, 2022
Signed-off-by: Jan N. Klug <github@klug.nrw>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: eec80f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2885
Signed-off-by: Jan N. Klug github@klug.nrw