Add ability to name timers / scheduled jobs #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
feature-namedtimers
branch
from
3b84992 to
bdea9cc
Compare
wborn
approved these changes
Jun 18, 2022
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/way-to-name-timers-in-js-scripting/138156/1 |
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Sep 13, 2022
Fixes openhab#159. Refers to openhab/openhab-core#2911. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to openhab/openhab-js
that referenced
this pull request
Sep 13, 2022
Fixes #159. Refers to openhab/openhab-core#2911. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-rules-tools
that referenced
this pull request
Sep 28, 2022
This change names the created timers with the user provided `key`. Refers to openhab/openhab-core#2911. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: c2ec97c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1255
Closes #2750
Potentially API breaking, although I think that alternative scheduler implementations are unlikely. I could add a default for the new method that just throws away the identifier.
Signed-off-by: Jan N. Klug github@klug.nrw