Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus] Add configurable after connection delay #2927

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Apr 22, 2022

An attempt to build base to solve Huawei SDongle issues defined in #2926.

@splatch splatch requested a review from a team as a code owner April 22, 2022 18:08
@wborn wborn added the enhancement An enhancement or new feature of the Core label Apr 22, 2022
@splatch splatch force-pushed the modbus-fix branch 2 times, most recently from fa28ecb to e032379 Compare April 22, 2022 21:23
Fixes openhab#2926.

Signed-off-by: Łukasz Dywicki <luke@code-house.org>
@wborn wborn requested a review from ssalonen April 22, 2022 22:15
…/openhab/core/io/transport/modbus/internal/pooling/ModbusSlaveConnectionFactoryImpl.java

Co-authored-by: Wouter Born <github@maindrain.net>
Copy link
Contributor

@ssalonen ssalonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit c09db50 into openhab:main Apr 23, 2022
@wborn wborn added this to the 3.3 milestone Apr 23, 2022
@wborn wborn changed the title [modbus] Add configurable after connection delay. [modbus] Add configurable after connection delay Apr 25, 2022
splatch added a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Fixes openhab#2926

Signed-off-by: Łukasz Dywicki <luke@code-house.org>
GitOrigin-RevId: c09db50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants