Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transformations not removed if file deleted #2945

Merged
merged 1 commit into from
May 5, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 1, 2022

The isRegularFile check fails for DELETE events. As a result deleted files where not removed from the registry.

Signed-off-by: Jan N. Klug github@klug.nrw

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label May 1, 2022
@J-N-K J-N-K requested a review from a team as a code owner May 1, 2022 12:28
@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels May 1, 2022
@J-N-K J-N-K force-pushed the bug-filetransformation branch from 02b8120 to c708bbb Compare May 5, 2022 17:07
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 53a072d into openhab:main May 5, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone May 5, 2022
@J-N-K J-N-K deleted the bug-filetransformation branch May 6, 2022 17:30
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 53a072d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants