Normalize Metadata configuration from managed provider #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikreuzer
reviewed
May 25, 2022
....openhab.core/src/main/java/org/openhab/core/internal/items/ManagedMetadataProviderImpl.java
Outdated
Show resolved
Hide resolved
kaikreuzer
reviewed
May 25, 2022
....openhab.core/src/main/java/org/openhab/core/internal/items/ManagedMetadataProviderImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
bug-bormalizemetadata
branch
from
323b8d6 to
daa814b
Compare
|
@kaikreuzer Do you think we can merge here, too? |
kaikreuzer
approved these changes
Sep 20, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Normalize Metadata configuration from managed provider Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: e3b90e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1904
The reason is that GSON de-serializes numeric metadata configuration values from JSON storage to
Double, while textual defined values areBigDecimal. This PR adds normalization of the entries provided by the managed provider.Signed-off-by: Jan N. Klug github@klug.nrw