Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] add semantics query endpoint to item resource #2985

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 29, 2022

Closes #2977

The approach here is a little bit broader than what was originally requested. The new endpoint delivers the item matching the provided semantic tag for a given item. To get the physical location, Location has to be used.

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K J-N-K requested a review from a team as a code owner May 29, 2022 18:01
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label May 29, 2022
@J-N-K J-N-K changed the title [rest] add semantics query to item resource [rest] add semantics query endpoint to item resource May 29, 2022
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Can you resolve the merge conflicts?

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K force-pushed the feature-restadditemsemantics branch from 3ef18d4 to 50b7a2e Compare October 30, 2022 14:17
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Oct 30, 2022

Done

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 3.4 milestone Oct 30, 2022
@cweitkamp cweitkamp merged commit d9bf8f7 into openhab:main Oct 30, 2022
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* [rest] add semantics query to item resource

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: d9bf8f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core REST/SSE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get physical location of an Item?
2 participants