Fix DateTime trigger syntax to not break the equals function in the execution script #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecution script Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
bug
|
Interesting. IIRC it didn't work for me with |
|
I only tested it within my IDE, but there it seemed to work. And compilation definitely worked, so Xtext does not see any conflict in the definition. |
|
I'm currently compiling your change locally to check that it also works in a regular runtime. |
J-N-K
approved these changes
Jun 6, 2022
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-3-milestone-discussion/132715/159 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a critical regression caused by #2963, which made the
equalsmethod disfunctional within rules.This resulted in log messages like:
It seems that Xtext is able to parse everything, if we use the same vocabulary as for the TimerTrigger, i.e. "is". The only drawback might be that the DateTime trigger cannot be used with items of name
midnightornoon, but I think this is acceptable.Signed-off-by: Kai Kreuzer kai@openhab.org