Log a warning when item for trigger/condition is missing or removed #3007
Conversation
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
The discussion linked in #2526 suggests that this should be addressed through the VSCode extension as it seems risky to add it to the runtime due to potential issues with the lifecycle of rules and items, especially when editing them at runtime. |
|
That‘s why I added it here and subscribed to the ItemAddedEvent/ItemRemovedEvent.That way runtime changes to items will be properly considered. And it also works for UI defined rules and all other languages, IMO it‘s superior to VSCode. |
There was a problem hiding this comment.
That way runtime changes to items will be properly considered.
I am not sure how this addresses potential lifecycle issues, but I assume you have tested this, so I'm fine here.
So just my wish to slightly improve the log messages remains, then we should be good to merge.
| properties.put("event.topics", topic); | ||
| eventSubscriberRegistration = this.bundleContext.registerService(EventSubscriber.class.getName(), this, | ||
| properties); | ||
|
|
||
| if (itemRegistry.get(groupName) == null) { | ||
| logger.warn("Group '{}' needed for rule '{}', trigger '{}' not present in registry. Trigger will not work.", |
There was a problem hiding this comment.
I think the message about the trigger is incorrect/misleading. The trigger is in the registry, the item is not.
I'd suggest to change it to something like, which is anyhow shorter and has all relevant information:
| logger.warn("Group '{}' needed for rule '{}', trigger '{}' not present in registry. Trigger will not work.", | |
| logger.warn("Group '{}' needed for rule '{}', Trigger '{}' will not work.", |
Same of course for all the other log messages.
Signed-off-by: Jan N. Klug <github@klug.nrw>
…penhab#3007) * Log a warning when item for trigger/condition is missing or removed Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 2ad0b73
Closes #2526
The solution here not only works for DSL but for all rules since the check is done in the module handler.
Signed-off-by: Jan N. Klug github@klug.nrw