Fix AuthFilter crash if trusted network not configured #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/authfilter-has-arrayindexoutofboundexception/139866/8 |
kaikreuzer
reviewed
Oct 12, 2022
...enhab.core.io.rest.auth/src/main/java/org/openhab/core/io/rest/auth/internal/AuthFilter.java
Outdated
Show resolved
Hide resolved
…b/core/io/rest/auth/internal/AuthFilter.java Co-authored-by: Kai Kreuzer <kai@openhab.org>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Fix AuthFilter crash if trusted network not configured Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: ef3b13f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3106
See also: https://community.openhab.org/t/authfilter-has-arrayindexoutofboundexception/139866/7
The code did not properly handle an empty network. This also adds test for implicit user role handling and trusted networks.
@openhab/core-maintainers I beliebe this is critical as it breaks all installations until either this is merged or the user configures a trusted network (which should not be done in general).
Signed-off-by: Jan N. Klug github@klug.nrw