Fix missing stateDescriptionProvider in Group items #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stateDescriptionProvider was not properly passed to the base item. Because of that units set in the state description were not properly used when setting the griup state after calculating aggregation functions. Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Nice catch. I am wondering if we should override the getter methods too and return the |
|
I guess that's not needed as they are the same. The base item is not allowed to be accessed except for instance checks (according to the JavaDoc). |
|
Hm, are you sure? If we override the setter and do not set the internal property it will be In ItemRegistryImplTest is a nice place to add a test case. |
|
Forget my comment. I missed the super calls. |
|
But we call |
cweitkamp
approved these changes
Nov 6, 2022
cweitkamp
approved these changes
Nov 6, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Fix missing stateDescriptionProvider in Group items The stateDescriptionProvider was not properly passed to the base item. Because of that units set in the state description were not properly used when setting the group state after calculating aggregation functions. Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 2bceba6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2449
The stateDescriptionProvider was not properly passed to the base item. Because of that units set in the state description were not properly used when setting the griup state after calculating aggregation functions.
Signed-off-by: Jan N. Klug github@klug.nrw