Refactor script dependency tracking #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
bug-dependencytracker
branch
from
3cc4606 to
abc6042
Compare
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
@openhab/core-maintainers If this should make it into 3.4 it should be reviewed ASAP. Even though I tested it for JS (and all other languages did not use dependency tracking, neither for file-based nor UI scripts/rules), there is the slight risk that it may break something. The broken API probably is not an issue since TTBOMK it was not used (except in the GraalJS add-on). |
wborn
reviewed
Nov 29, 2022
...penhab/core/automation/module/script/rulesupport/loader/AbstractScriptDependencyTracker.java
Outdated
Show resolved
Hide resolved
...penhab/core/automation/module/script/rulesupport/loader/AbstractScriptDependencyTracker.java
Outdated
Show resolved
Hide resolved
.../org/openhab/core/automation/module/script/rulesupport/loader/AbstractScriptFileWatcher.java
Show resolved
Hide resolved
.../openhab/core/automation/module/script/rulesupport/loader/AbstractScriptFileWatcherTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/openhab/core/automation/module/script/internal/ScriptEngineManagerImplTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 4bcc15d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166
This needs to be merged together with the corresponding PR in openhab-addons, otherwise jsscripting will break.
With this change every
ScriptEngineFactorycan provide aDependencyTrackerthat is injected in the execution context. Dependencies are tracked by an identifier (usually a path). Services implementingDependencyTracker.Listenerare notified of the script that need reloading by theengineIdentifierof the script engine.The new structure allows decoupling of script/rule providers (file-based / UI based) and dependency trackers.
Signed-off-by: Jan N. Klug github@klug.nrw