Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure metadata available at startlevel 20 #3273

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 28, 2022

This makes the MetadataRegistry report when the elements of the ManagedMetadataProvider is available via a ready marker (like other registries). This is needed to properly determine the unit for restoring values from persistence. I labelled it as "bug" because I believe it could explain some strange behavior that has been reported in rare cases when restoring values during startup.

This is independent from the discussion in #3248.

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Dec 28, 2022
@J-N-K J-N-K requested a review from a team as a code owner December 28, 2022 09:21
@J-N-K J-N-K changed the title Ensure metadata available at start-level 20 Ensure metadata available at startlevel 20 Dec 28, 2022
J-N-K added 2 commits January 3, 2023 21:36
This makes the `MetadataRegistry` report when the elements of the `ManagedMetadataProvider` is available via a ready marker (like other registries).

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K force-pushed the feature-metadataloaded branch from 0c43319 to 938850e Compare January 3, 2023 20:36
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a moment to see that openhab/openhab-distro#1451 is the other part of the fix - together it all makes sense then. 😄

@kaikreuzer kaikreuzer merged commit a09ad3d into openhab:main Jan 10, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jan 10, 2023
@J-N-K J-N-K deleted the feature-metadataloaded branch January 10, 2023 21:25
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* Ensure metadata available at start-level 20

This makes the `MetadataRegistry` report when the elements of the `ManagedMetadataProvider` is available via a ready marker (like other registries).

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: a09ad3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants