Fix DateTimeTrigger not triggering on restored state #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
During startup most likely the item state is `UndefType.NULL` which results in no triggering. States are restored from persistence by directly setting the item state, not by an `ItemStateEvent` and were therefore missed. Since changing the trigger is not necessary when the state updates but does not change, the event listening was changed to `ItemStateChangedEvent` only. Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
bug-datetimetrigger
branch
from
fb123da to
e26d664
Compare
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
During startup most likely the item state is `UndefType.NULL` which results in no triggering. States are restored from persistence by directly setting the item state, not by an `ItemStateEvent` and were therefore missed. Since changing the trigger is not necessary when the state updates but does not change, the event listening was changed to `ItemStateChangedEvent` only. Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 6cd6f6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on the forum: https://community.openhab.org/t/trigger-based-on-datetime-item-not-firing-after-restart-server/142608
During startup most likely the item state is
UndefType.NULLwhich results in no triggering. States are restored from persistence by directly setting the item state, not by anItemStateEventand were therefore missed. Since changing the trigger is not necessary when the state updates but does not change, the event listening was changed toItemStateChangedEventonly.Signed-off-by: Jan N. Klug github@klug.nrw