Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to rule summary for Role.USER #3392

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Allow access to rule summary for Role.USER #3392

merged 1 commit into from
Feb 21, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 20, 2023

Fixes #3390

This allows access to the rule summary list also for users (i.e. unauthenticated). The rule itself is hidden as it may contain sensitive information.

@J-N-K
Allow access to rule summary for Role.USERS
1053c0b 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added enhancement An enhancement or new feature of the Core REST/SSE labels Feb 20, 2023
@J-N-K J-N-K requested a review from a team as a code owner February 20, 2023 20:52
@hmerk
Copy link

hmerk commented Feb 20, 2023

Thanks @J-N-K for providing this PR !!!

@hmerk hmerk mentioned this pull request Feb 20, 2023
Merged
@stefan-hoehn
Copy link
Contributor

Thanks, Jan, for the really fast response. IMHO LGTM.

kaikreuzer
kaikreuzer approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kaikreuzer kaikreuzer added this to the 4.0 milestone Feb 21, 2023
@kaikreuzer kaikreuzer merged commit f48200c into openhab:main Feb 21, 2023
@J-N-K J-N-K deleted the feature-allowrulesummaryforusers branch February 21, 2023 18:53
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
Allow access to rule summary for Role.USERS (openhab#3392)
acf9ee4 
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: f48200c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core REST/SSE
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

REST endpoint /rules should be accessible without admin rights
4 participants
@J-N-K @hmerk @stefan-hoehn @kaikreuzer