[Sitemap] Add new color keyword "itemValue"

[lolodomo]

Closes #3429

Signed-off-by: Laurent Garnier lg.hc@free.fr

[lolodomo]

With this item:

Color TestColor "Test color [%s]"

and this sitemap:

{
        Frame label="Using itemValue" {
                Text item=TestColor label="Color RGB [%rgb%]" icon="if:mdi:lightbulb" iconcolor=["itemValue"] labelcolor=["itemValue"] valuecolor=["itemValue"]
                Colorpicker item=TestColor icon="if:mdi:lightbulb" iconcolor=["itemValue"] labelcolor=["itemValue"] valuecolor=["itemValue"]
        }
        Frame label="Using color names" {
                Text item=TestColor icon="if:mdi:lightbulb" iconcolor=["pink"] labelcolor=["orange"] valuecolor=["purple"]
        }
        Frame label="Using color codes" {
                Text item=TestColor icon="if:mdi:lightbulb" iconcolor=["#ff0000"] labelcolor=["#00FF00"] valuecolor=["#0000ff"]
        }
}

here is the result in Basic UI after selecting a color with the picker:

REST sitemap API is adjusted:

[mherwege]

What item color is being used when the color is with a condition? Would it pick the color of the item being shown, or the color of the item on which the condition applies?

[lolodomo]

the color of the item being shown

[J-N-K]

Thanks, otherwise LGTM.

[J-N-K]

Suggested change

	if (item instanceof ColorItem && item.getState() instanceof HSBType) {
	HSBType hsbState = (HSBType) item.getState();
	itemRGBHexCode = "#" + Integer.toHexString(hsbState.getRGB()).substring(2);
	}
	if (item.getState() instanceof HSBType hsbState) {
	itemRGBHexCode = "#" + Integer.toHexString(hsbState.getRGB()).substring(2);
	}

If the state is of HSBType it must be a ColorItem. You can further reduce code by using pattern matching.

[lolodomo]

Your proposal will lead to a NPE when item is null.
But I could have a State as parameter rather than an Item if we consider that a test on HSBType is sufficient.

[J-N-K]

item != null would then be sufficient. But does it make sense to call the method at all if the item is null? If you need to add a check for each call, then I would prefer to add item != null here.

[lolodomo]

Changed. I am now passing as argument the item state.

[lolodomo]

@J-N-K : gentle ping

[J-N-K]

LGTM,thanks,

[jlaur]

@lolodomo - should this be mentioned in the documentation?

[lolodomo]

@lolodomo - should this be mentioned in the documentation?

Doc has been updated.
openhab/openhab-docs#2032