[voice] Add console commands for register/unregister dialogs and list them #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialogs and dialog registrations Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
voice/register_cmds
branch
from
2e2418a to
ef85d38
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/habot-walkthrough-9-n-configuring-voice-input/59879/5 |
lolodomo
suggested changes
Apr 14, 2023
...b.core.voice/src/main/java/org/openhab/core/voice/internal/VoiceConsoleCommandExtension.java
Outdated
Show resolved
Hide resolved
...b.core.voice/src/main/java/org/openhab/core/voice/internal/VoiceConsoleCommandExtension.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
|
Thank you for the review. Should I update the documentation for these commands? |
Yes please, but wait for the merge first. |
|
Hey @openhab/core-maintainers, I saw yesterday the oh release schedule, do you think this change can be merged before the feature freeze? |
J-N-K
approved these changes
Jul 2, 2023
kaikreuzer
approved these changes
Jul 2, 2023
J-N-K
changed the title
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
… them (openhab#3459) * [voice] Add voice commands for register/unregister dialogs and list dialogs and dialog registrations Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com> GitOrigin-RevId: 6b91416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add new cli voice commands for exposing the new register/unregister dialog capability of the voice manager, plus commands for list existing dialog registrations and running dialogs.
Also fixes a command description issue where the parameter "hlis" was documented as "interpreters". I think that "hlis" is better as it is sorter, but let me know if there is a preference over "interpreters".
Related to #3265