Fix variable binding in ScriptTransformationService #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by setting all attributes before compiling Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
J-N-K
added
bug
|
Thanks for merging! @openhab/core-maintainers could this please be applied to 3.4.x too? |
This was referenced Mar 20, 2023
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
ccutrer
pushed a commit
to openhab/openhab-jruby
that referenced
this pull request
Mar 21, 2023
and remove the need for giving input variable hints for the compiler openhab/openhab-core#3464 If this doesn't propagate to openhab 3.4.x, we need to add a note about it. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
by setting all attributes before compiling Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> GitOrigin-RevId: cb38d19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by setting all attributes before compiling.
In JRuby, because an identifier can either be a variable or a method call, the compiler needs to know variables ahead of time in order to recognise them as variables. Because scripts are compiled first, and then the attributes set, this information is missing, therefore a "hack" was needed in jruby transformations to give the compiler the needed hint.
This PR simply reverses the order so that attributes were set before compiling, so the hack in jruby will no longer be needed. I have tested this on my jrubyscripting addon installation.
For more info, see jruby/jruby#5876