Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AbstractDependencyTracker #3510

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Fix AbstractDependencyTracker #3510

merged 3 commits into from
Apr 1, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Mar 30, 2023

Reported in private communication. This is the same issue that was already fixed in #3457. The .canRead check failed because it was done on a relative path instead of an absolute one.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Mar 30, 2023
@J-N-K J-N-K requested a review from a team as a code owner March 30, 2023 17:33
Signed-off-by: Jan N. Klug <github@klug.nrw>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again, thanks!!

I think you have a typo in the PR description, I guess the other PR was #3457.

…src/test/java/org/openhab/core/automation/module/script/rulesupport/loader/AbstractScriptDependencyTrackerTest.java

Co-authored-by: Wouter Born <github@maindrain.net>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit d557a64 into openhab:main Apr 1, 2023
@wborn wborn added this to the 4.0 milestone Apr 1, 2023
@J-N-K J-N-K deleted the depwatcher branch April 1, 2023 12:16
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: d557a64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants