Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recently introduced SAT issues #3516

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Fix recently introduced SAT issues #3516

merged 2 commits into from
Apr 1, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 1, 2023

This PR fixes some recently introduced SAT issues.

@wborn
Fix recently introduced SAT issues
6507ba1 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner April 1, 2023 13:22
@wborn
Disable broken tests
4a8633e 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Member Author

wborn commented Apr 1, 2023

Looks like the tests in WatchServiceImplTest (added in #3004) never ran because the @Test annotated methods were private. Maybe you can have a look at it @J-N-K ?

@J-N-K
Copy link
Member

J-N-K commented Apr 1, 2023

Sure.

J-N-K
J-N-K approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clean-up. I'll check the tests in another PR.

@J-N-K J-N-K merged commit 4851bfb into openhab:main Apr 1, 2023
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Apr 1, 2023
@J-N-K J-N-K added this to the 4.0 milestone Apr 1, 2023
@J-N-K J-N-K mentioned this pull request Apr 1, 2023
Merged
@wborn wborn deleted the sat-fixes branch April 1, 2023 21:01
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@wborn @splatch
Fix recently introduced SAT issues (openhab#3516)
cd92c3a 
* Fix recently introduced SAT issues

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 4851bfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @J-N-K