Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider auto-update policy from channel types #3575

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Apr 24, 2023

When the Main UI creates things/channels through the REST API, it does not set autoUpdatePolicy for the channels, which makes the core use "RECOMMEND" as a policy without looking at a potential information at the channel type definition.

This PR leaves the autoUpdatePolicy for the channels unset, so that the AutoUpdateManager then checks for the information in the channel type.

See also openhab/openhab-addons#14809 (comment)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from a team as a code owner April 24, 2023 07:58
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Apr 24, 2023
@kaikreuzer kaikreuzer changed the title Consider auto-update veto from channel types Consider auto-update policy from channel types Apr 24, 2023
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@J-N-K J-N-K added this to the 4.0 milestone Apr 24, 2023
@J-N-K J-N-K merged commit ac0f512 into openhab:main Apr 24, 2023
@J-N-K J-N-K mentioned this pull request Apr 29, 2023
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: ac0f512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants