Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storing of StateDescriptionFragment in AbstractStorageBasedTypeProvider #3598

Merged
merged 1 commit into from
May 9, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 9, 2023

@lolodomo FYI.

Since StateDescriptionFragment is an interface it can't be restored from the storage without adding type specific converters. Since JsonStorage does not provide a solution for that, the StateDescriptionFragment is now mapped to a storage entity.

…ovider

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label May 9, 2023
@J-N-K J-N-K marked this pull request as ready for review May 9, 2023 14:33
@J-N-K J-N-K requested a review from a team as a code owner May 9, 2023 14:33
@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels May 9, 2023
@kaikreuzer kaikreuzer merged commit 67b80af into openhab:main May 9, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone May 9, 2023
@J-N-K J-N-K deleted the bug-abstracstoragebasedprovider branch May 9, 2023 16:11
@lolodomo
Copy link
Contributor

lolodomo commented May 9, 2023

Thank you, I will try again tomorrow with the new snapshot.

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
…ovider (openhab#3598)

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 67b80af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants