Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UoM] add unit rpm for rotational frequency #3616

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

boehan
Copy link
Contributor

@boehan boehan commented May 15, 2023

Adds unit rpm (revolutions per minute) for rotational frequency. Even though I'd prefer min⁻¹, rpm seems to be more common.
Please let me know, if I missed something. I have to admit that this is untested as core does currently not build for me locally.

Signed-off-by: Hans Böhm <h.boehm@gmx.at>
@boehan boehan requested a review from a team as a code owner May 15, 2023 18:27
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/binding-improvements-best-practice/146664/5

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Hans Böhm <h.boehm@gmx.at>
GitOrigin-RevId: f92424c
@wborn wborn added the enhancement An enhancement or new feature of the Core label Jul 15, 2023
@wborn wborn added this to the 4.0 milestone Jul 15, 2023
@wborn wborn added the UoM Units of Measurement label Jul 15, 2023
@wborn wborn mentioned this pull request Jul 15, 2023
boehan added a commit to boehan/openhab-docs that referenced this pull request Jul 16, 2023
Related to openhab/openhab-core#3608
Related to openhab/openhab-core#3616
Related to openhab/openhab-core#3684

Signed-off-by: Hans Böhm <boehan@users.noreply.github.com>
Confectrician pushed a commit to openhab/openhab-docs that referenced this pull request Jul 16, 2023
Related to openhab/openhab-core#3608
Related to openhab/openhab-core#3616
Related to openhab/openhab-core#3684

Signed-off-by: Hans Böhm <boehan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core UoM Units of Measurement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants