[ColorUtil] optimise constants; hue overflow check #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
J-N-K
requested changes
May 25, 2023
bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
J-N-K
approved these changes
May 26, 2023
andrewfg
commented
May 26, 2023
| } | ||
| if (hue.compareTo(BigDecimal.ZERO) < 0) { | ||
| hue = hue.add(BigDecimal.valueOf(360)); | ||
| hue = hue.add(BIG_DECIMAL_360); | ||
| } else if (hue.compareTo(BIG_DECIMAL_360) > 0) { |
There was a problem hiding this comment.
@J-N-K just re-reading this line, I think it should be >= rather than > to cover the exact edge case where hue is 360. Or??
There was a problem hiding this comment.
No, I think it's fine. If that is the case 360-360=0 which is the same color.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* [ColorUtil] define constants; fix hue overflow Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> GitOrigin-RevId: 4d3535a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements to ColorUtils..
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch