Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AuthFilter service declaration #3651

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jun 11, 2023

Regression from #3622

The AuthFilter no longer declared ContainerRequestFilter as service.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of the Core critical regression labels Jun 11, 2023
@J-N-K J-N-K requested a review from a team as a code owner June 11, 2023 19:12
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh4-sign-in-fails-repeteadly-on-snapshot/147207/5

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 7e734b8 into openhab:main Jun 11, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jun 11, 2023
@J-N-K J-N-K deleted the authfilter branch June 11, 2023 19:22
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 7e734b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core critical regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants