Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rest] Add missing fields to /rest/items?staticDataOnly=true resource #3712

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[rest] Add missing fields to /rest/items?staticDataOnly=true resource #3712

merged 1 commit into from
Jul 21, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jul 18, 2023 •
edited
Loading

Fixes openhab/openhab-webui#1958.

I have checked the contents of those two fields, they should not change without a user-change to the Item.

@openhab/core-maintainers Can this please be merged for openHAB 4? The linked UI issue is a regression from openhab/openhab-webui#1661 and #3335.

@ghys FYI.

@florian-h05
[rest] Add missing fields to /rest/items?staticDataOnly=true resource
c89a7f9 
Fixes #openhab/openhab-webui#1958.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner July 18, 2023 13:26
@ghys
Copy link
Member

ghys commented Jul 18, 2023

I left those out because command/state descriptions can be provided with resp. DynamicCommandDescriptionProvider or DynamicStateDescriptionProvider (mostly for having dynamic options).
The main UI's command options picker will still do a GET /items/{name} every time to fetch the newest options though, so it's IMHO acceptable to include them in the staticDataOnly output to fix the referenced issue.

@florian-h05
Copy link
Contributor Author

@J-N-K Any chance to get this merged before the code freeze?

J-N-K
J-N-K approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Jul 21, 2023
@J-N-K J-N-K merged commit 72ec0f3 into openhab:main Jul 21, 2023
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 21, 2023
@J-N-K J-N-K added this to the 4.0 milestone Jul 21, 2023
@florian-h05 florian-h05 deleted the items-staticdataonly branch July 21, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

List Item Widget Command Options Read Only
3 participants
@florian-h05 @ghys @J-N-K