Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation] Update texts for rule-based actions #3733

Merged
merged 1 commit into from
Jul 30, 2023
Merged

[automation] Update texts for rule-based actions #3733

merged 1 commit into from
Jul 30, 2023

Conversation

florian-h05
Copy link
Contributor

Core part of openhab/openhab-webui#1921.

With UI-support for scenes & scripts, the texts (labels, descriptions etc.) for rule-based actions should be updated to mention scenes & scripts as well. This improves the UI experience.

Core part of openhab/openhab-webui#1921.

With UI-support for scenes & scripts, the texts (labels, descriptions etc.) for rule-based actions should be updated to mention scenes & scripts as well.
This improves the UI experience.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner July 28, 2023 12:33
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Jul 28, 2023
Closes openhab#1921.
Depends on openhab/openhab-core#3733.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@kaikreuzer kaikreuzer merged commit c4fb71f into openhab:main Jul 30, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Jul 30, 2023
@florian-h05 florian-h05 deleted the webui-1921 branch July 30, 2023 18:27
ghys pushed a commit to openhab/openhab-webui that referenced this pull request Aug 19, 2023
Closes #1921.
Depends on openhab/openhab-core#3733.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants