Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CME in RuleEngineImpl #3754

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Fix CME in RuleEngineImpl #3754

merged 1 commit into from
Aug 13, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Aug 12, 2023

Fix #3752

@J-N-K
Fix CME in RuleEngineImpl
c60ea25 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Aug 12, 2023
@J-N-K J-N-K requested a review from a team as a code owner August 12, 2023 18:59
wborn
wborn approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit da73b57 into openhab:main Aug 13, 2023
@wborn wborn added this to the 4.1 milestone Aug 13, 2023
@jlaur
Copy link
Contributor

jlaur commented Aug 13, 2023

@wborn, @J-N-K - this fix seems low risk, perhaps it's worthy of being cherry-picked in 4.0.x?

@J-N-K J-N-K deleted the fix-cme-ruleengineimpl branch August 13, 2023 16:27
@J-N-K
Copy link
Member Author

J-N-K commented Aug 13, 2023

Probably. I can't imagine how it should break something.

wborn pushed a commit that referenced this pull request Aug 14, 2023
@J-N-K @wborn
Fix CME in RuleEngineImpl (#3754)
e7cabd8 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[ERROR] [e.automation.internal.RuleEngineImpl] - Failed to execute rule 'RULE-NAME': null
3 participants
@J-N-K @jlaur @wborn