Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap Generator: Fix trailing space in state string #3812

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

mherwege
Copy link
Contributor

Fixes openhab/openhab-webui#2082

#3769 fixes an issue with blanks in visibility or color command arguments. It did overlook trailing blanks in color arguments and included them in the argument.
This PR fixes this issue.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner September 25, 2023 10:42
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@kaikreuzer kaikreuzer merged commit 3eef287 into openhab:main Oct 1, 2023
2 checks passed
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Oct 1, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Oct 1, 2023
@kaikreuzer kaikreuzer changed the title [sitemap mainUI] fix trailing space in state string Fix trailing space in state string Oct 1, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Oct 2, 2023

Is it correct to prefix the PR title with "Sitemap generator"?
The current title is not enough precise.

@kaikreuzer kaikreuzer changed the title Fix trailing space in state string Sitemap Generator: Fix trailing space in state string Oct 3, 2023
@kaikreuzer
Copy link
Member

I've changed the title.

@mherwege mherwege deleted the sitemap_ui_spaces_fix branch October 16, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sitemap Label Colour not working
3 participants