Make DecimalType, QuantityType, PercentType accept lowercased exponent notation #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this notation is to be supported I would also expect it to be supported by all the others types such as PercentType and QuantityType. There don't seem to be any unit tests for those that indicate it is supported. |
jimtng
force-pushed
the
decimaltype-uppercase
branch
from
b2d682b to
e5773ab
Compare
jimtng
changed the title
jimtng
force-pushed
the
decimaltype-uppercase
branch
from
e5773ab to
b8f7739
Compare
…t notation Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
decimaltype-uppercase
branch
from
b8f7739 to
b027633
Compare
wborn
reviewed
Oct 7, 2023
bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/QuantityType.java
Outdated
Show resolved
Hide resolved
jimtng
force-pushed
the
decimaltype-uppercase
branch
2 times, most recently
from
d574864 to
c4bbd56
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
decimaltype-uppercase
branch
from
c4bbd56 to
ee1743d
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
This breaks the KNX tests, see https://github.com/openhab/openhab-addons/actions/runs/6461008060/job/17539806529?pr=15723
|
|
This is because the regex is too restrictive as I mentioned above. Perhaps we do need to change it to a broader pattern after all. |
jimtng
added a commit
to jimtng/openhab-webui
that referenced
this pull request
Aug 7, 2024
Core now accepts lowercased exponent since openhab/openhab-core#3834 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
lolodomo
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Aug 8, 2024
Core now accepts lowercased exponent since openhab/openhab-core#3834 @mherwege would you mind verifying this please? Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3833 and openhab/openhab-addons#13371