[modbus] reduce log level when modbus slave returns DEVICE_BUSY exception #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This exception is meant to indicate that the request should be retried shortly, essentially, and at least some of the devices I own seem to be busy bees. Thus my logs receive significant spam of this warning. Since the exception is transient and retrying it is the expected course of action, I think it makes sense to reduce the log level here slightly and only output an error when the retries get exhausted. Signed-off-by: Simonas Kazlauskas <git@kazlauskas.me>
J-N-K
requested changes
Oct 31, 2023
| @@ -662,7 +668,11 @@ private <R, C extends ModbusResultCallback, F extends ModbusFailureCallback<R>, | |||
| } catch (ModbusSlaveException e) { | |||
| lastError.set(new ModbusSlaveErrorResponseExceptionImpl(e)); | |||
| // Slave returned explicit error response, no reason to re-establish new connection | |||
| if (willRetry) { | |||
| if (willRetry && e.getType() == MODBUS_EXCEPTION_SLAVE_DEVICE_BUSY) { | |||
| logger.info( | |||
There was a problem hiding this comment.
When re-trying is an expected operation, you can reduce that to DEBUG.
|
@nagisa : did you see the review comment? |
nagisa
commented
Dec 11, 2023
...rt.modbus/src/main/java/org/openhab/core/io/transport/modbus/internal/ModbusManagerImpl.java
Outdated
Show resolved
Hide resolved
…/openhab/core/io/transport/modbus/internal/ModbusManagerImpl.java Signed-off-by: Simonas Kazlauskas <github@kazlauskas.me>
|
@J-N-K : you can probably merge this PR now. |
wborn
added
bug
J-N-K
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exception is meant to indicate that the request should be retried shortly, essentially, and at least some of the devices I own seem to be busy bees. Thus my logs receive significant spam of this warning.
Since the exception is transient and retrying it is the expected course of action, I think it makes sense to reduce the log level here slightly and only output an error when the retries get exhausted.