Improve FolderObserver ignored paths handling #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FolderObserver needs to make sure that paths are properly handled for any parsers that are added at any moment by other threads during activation. Fixes openhab#3784 Fixes openhab#3793 Signed-off-by: Wouter Born <github@maindrain.net>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/all-things-are-gone-after-restarting-openhab/145076/27 |
|
Maybe something to backport in 4.0 ? |
Yes it would be nice to finally have this fixed so I've just cherry picked it. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/item-configuration-file-changes-not-detected-in-oh-4-0-4/151972/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FolderObserver needs to make sure that paths are properly handled for any parsers that are added at any moment by other threads during activation.
Fixes #3784
Fixes #3793
To test the fix, update the bundle on the Karaf console using one of these commands and then restart openHAB.
OH 4.0.x
bundle:update org.openhab.core.model.core https://github.com/wborn/openhab-core/releases/download/folder-observer-20231020/org.openhab.core.model.core-4.0.4-SNAPSHOT.jarRecent OH 4.1.0-SNAPSHOTs or OH 4.1.0.M2
bundle:update org.openhab.core.model.core https://github.com/wborn/openhab-core/releases/download/folder-observer-20231020/org.openhab.core.model.core-4.1.0-SNAPSHOT.jar