adapted AutoUpdateDelegate to the new ESH auto update infrastructure #390
Conversation
Related to eclipse-archived/smarthome#5011 Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Note to reviewers: This code will only compile / can only be merged once eclipse-archived/smarthome#5011 is merged and a new ESH stable has been built. |
|
FTR, eclipse-archived/smarthome#5011 is merged. I'd do a new ESH Stable once one of @openhab/2-x-add-ons-maintainers approves (but not yet merges!) this PR. |
| synchronized (itemUpdateVetos) { | ||
| itemUpdateVetos.clear(); | ||
| for (Item item : itemRegistry.getAll()) { | ||
| for (org.openhab.core.autoupdate.AutoUpdateBindingProvider provider : providers) { |
There was a problem hiding this comment.
Yes, indeed, now that it is removed from ESH :-)
| itemUpdateVetos.clear(); | ||
| for (Item item : itemRegistry.getAll()) { | ||
| for (org.openhab.core.autoupdate.AutoUpdateBindingProvider provider : providers) { | ||
| Boolean autoUpdate = provider.autoUpdate(item.getName()); |
There was a problem hiding this comment.
Does it really return a Boolean with potential null's?
There was a problem hiding this comment.
Yes. A provider returns null if it does not want to do any statement.
| synchronized (itemUpdateVetos) { | ||
| boolean removed = itemUpdateVetos.remove(itemName); | ||
| for (org.openhab.core.autoupdate.AutoUpdateBindingProvider provider : providers) { | ||
| Object autoUpdate = provider.autoUpdate(itemName); |
There was a problem hiding this comment.
In other places we at least use a Boolean...
|
|
||
| @Reference(cardinality = ReferenceCardinality.MULTIPLE) | ||
| public void addAutoUpdateBindingProvider(org.openhab.core.autoupdate.AutoUpdateBindingProvider provider) { |
There was a problem hiding this comment.
It seems we can import these now, given the one from ESH is not imported anymore.
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Thanks - I have updated the PR. |
|
Retriggering PR builds... |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Nice, DS annotations actually caught a bug in the unset method. Fixed it with 8f3dea0. |
|
@martinvw All green now, so I think we can merge! |
…penhab#390) * adapted AutoUpdateDelegate to the new ESH auto update infrastructure Related to eclipse-archived/smarthome#5011 Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab2-mysql-persistence-setup/15829/67 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/vera-mios-bindings-for-beginner/23884/13 |
…penhab#390) * adapted AutoUpdateDelegate to the new ESH auto update infrastructure Related to eclipse-archived/smarthome#5011 Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: 47c2e33
Related to eclipse-archived/smarthome#5011
While at it, I also changed the DS components to use annotations instead of XMLs.
Signed-off-by: Kai Kreuzer kai@openhab.org