Make logger for jar file add-ons configurable in UI #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
|
@mherwege if I install via Eclipse Dev Environment an addon, no logging configuration appears in MainUI for the addon. |
It depends on Karaf functionality which is unavailable when debugging in Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-ons provided as jar files in the addons in the add-on folder did not have any information about loggers, so the logger could not be set through the UI.
As jar files are often provided to test new add-on functionality, the ability to set logging in the UI is relevant.
This PR adds the symbolic name as the name for the logger, which should be the main logger for most of the jar file provided add-ons.