Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPnP add M-SEARCH for root devices #3933

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

andrewfg
Copy link
Contributor

Following release of OH v4.1M5 some users found that the new Add-on Suggestion Finder was not discovering all UPnP devices on their LAN.

The OH UPnP discovery mechanism currently sends an M-SEARCH broadcast with a search target ST: ssdp:all header -- yet some devices do not respond to broadcasts with ST: ssdp:all and only respond to broadcasts with ST: upnp:rootdevice.

This PR adds a M-SEARCH broadcast with search target ST: upnp:rootdevice.

The functionality of this PR was tested already live via openhab/openhab-addons#16077

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from a team as a code owner December 19, 2023 10:50
@andrewfg
Copy link
Contributor Author

@mherwege / @jlaur / @hmerk - 4yi.

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit 3362bfb into openhab:main Dec 19, 2023
3 checks passed
@wborn wborn added the enhancement An enhancement or new feature of the Core label Dec 19, 2023
@wborn wborn added this to the 4.1 milestone Dec 19, 2023
@andrewfg andrewfg deleted the m-search-target branch August 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants