Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build number reporting at startup #3991

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix build number reporting at startup #3991

merged 1 commit into from
Jan 2, 2024

Conversation

kaikreuzer
Copy link
Member

openHAB currently logs during startup something like

22:09:04.949 [INFO ] [org.openhab.core.Activator          ] - Starting openHAB 4.2.0 (build Unknown Build No.)

The word build seems unnecessary here.

  • In case of a release build, the version.properties file contains Release Build
  • In case of a snapshot build, the version.properties file contains Build #3814

In all cases, we hence do not need the word build before it.

@kaikreuzer
Fix build number reporting at startup
e059fda 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Jan 1, 2024
@kaikreuzer kaikreuzer requested a review from a team as a code owner January 1, 2024 21:19
wborn
wborn approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@wborn wborn merged commit 30ae005 into openhab:main Jan 2, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Jan 2, 2024
cipianpascu pushed a commit to cipianpascu/openhab-core that referenced this pull request Jan 17, 2024
@kaikreuzer
Fix build number reporting at startup (openhab#3991)
d6fc1c2 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kaikreuzer @wborn