Iterate using Map entries #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-N-K
requested changes
Jan 3, 2024
| for (String stateVariable : values.keySet()) { | ||
| StateVariableValue value = values.get(stateVariable); | ||
| for (Entry<String, StateVariableValue> entry : values.entrySet()) { | ||
| StateVariableValue value = entry.getValue(); | ||
| if (value.getValue() != null) { |
There was a problem hiding this comment.
I think this null-check can be omitted if we use entry.getValue() because the map has no null values.
There was a problem hiding this comment.
I'm getting NPE's I believe due to the removal of the null check here. I've opened #4037 to track that.
| ConfigDescriptionParameter configDescriptionParameter = map.get(key); | ||
| for (Entry<String, ConfigDescriptionParameter> entry : map.entrySet()) { | ||
| String key = entry.getKey(); | ||
| ConfigDescriptionParameter configDescriptionParameter = entry.getValue(); | ||
| if (configDescriptionParameter != null) { |
There was a problem hiding this comment.
I think this null-check can be omitted if we use entry.getValue() because the map has no null values.
Comment on lines
154
to
155
| List<String> vendorPortfolio = entry.getValue(); | ||
| return vendorPortfolio == null ? List.of() : vendorPortfolio; |
There was a problem hiding this comment.
Suggested change
| List<String> vendorPortfolio = entry.getValue(); | |
| return vendorPortfolio == null ? List.of() : vendorPortfolio; | |
| return entry.getValue(); |
The map does not contain null values
Iteration using Map entries is preferred because it is more efficient and helps preventing NPEs. Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
wborn
force-pushed
the
entryset-iteration
branch
from
b735611 to
c0a75e8
Compare
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
* Iterate using Map entries Iteration using Map entries is preferred because it is more efficient and helps preventing NPEs. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration using Map entries is preferred because it is more efficient and helps preventing NPEs.