Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary semicolons #4009

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove unnecessary semicolons #4009

merged 1 commit into from
Jan 3, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 3, 2024

This helps with stopping the proliferation of unnecessary semicolons.

@wborn
Remove unnecessary semicolons
b7bdcec 
This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner January 3, 2024 11:33
J-N-K
J-N-K approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can have a SAT check for that?

@wborn
Copy link
Member Author

wborn commented Jan 3, 2024

I think that should be possible because Checkstyle has some checks for this:

See: https://checkstyle.sourceforge.io/checks.html

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Jan 3, 2024
@J-N-K J-N-K added this to the 4.2 milestone Jan 3, 2024
@J-N-K J-N-K merged commit 106c8b2 into openhab:main Jan 3, 2024
3 checks passed
@wborn wborn deleted the remove-unnecessary-semicolons branch January 3, 2024 12:47
cipianpascu pushed a commit to cipianpascu/openhab-core that referenced this pull request Jan 17, 2024
@wborn
Remove unnecessary semicolons (openhab#4009)
fee7c6b 
This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @J-N-K