Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging in ChannelCommandDescriptionProvider #4040

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix logging in ChannelCommandDescriptionProvider #4040

merged 1 commit into from
Jan 15, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 14, 2024

The class of the broken provider should be logged, not the class of the command description.

Found while investigating openhab/openhab-addons#14747

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jan 14, 2024
@J-N-K J-N-K requested a review from a team as a code owner January 14, 2024 20:51
wborn
wborn reviewed Jan 14, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase the PR? It shows lots of unrelated changes. 🤔

@wborn @J-N-K
Fix logging in ChannelCommandDescriptionProvider
93dc736 
The class of the the broken provider should be logged, not the class of the command description.

Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
wborn approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit c82a9e6 into openhab:main Jan 15, 2024
2 of 3 checks passed
@wborn wborn added this to the 4.2 milestone Jan 15, 2024
@J-N-K J-N-K deleted the fix-logging branch January 15, 2024 21:38
cipianpascu pushed a commit to cipianpascu/openhab-core that referenced this pull request Jan 17, 2024
@J-N-K
Fix logging in ChannelCommandDescriptionProvider (openhab#4040)
739ffef 
The class of the the broken provider should be logged, not the class of the command description.

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
@lolodomo
Copy link
Contributor

lolodomo commented Jan 27, 2024 •
edited
Loading

Could be interesting to also fix that in 4.1.x to have updated feedbacks without waiting for end of June.
@J-N-K @wborn WDYT ?

wborn pushed a commit that referenced this pull request Jan 27, 2024
@J-N-K @wborn
Fix logging in ChannelCommandDescriptionProvider (#4040)
bad829f 
The class of the the broken provider should be logged, not the class of the command description.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@wborn
Copy link
Member

wborn commented Jan 27, 2024

It's been cherry-picked now. 🙂

@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @lolodomo @wborn