[marketplace] Update CommunityUIWidgetAddonHandler.java to give a more helpful error #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing from marketplace gives an Error that is not very helpful. Couldn’t find the widget in the add-on entry The cause was missing ```yaml code fence when a normal code fence was used. This used to work in the past so a number of widgets are done this way and will not install. Suggest a more useful message to help guide widget devs. Signed-off-by: Matthew Skinner <matt@pcmus.com>
wborn
reviewed
Jan 20, 2024
...ava/org/openhab/core/addon/marketplace/internal/community/CommunityUIWidgetAddonHandler.java
Outdated
Show resolved
Hide resolved
…penhab/core/addon/marketplace/internal/community/CommunityUIWidgetAddonHandler.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
Sorry @wborn missed your suggestion on my. Mobile phone screen. Accepted your suggestion Thanks. |
wborn
requested changes
Jan 20, 2024
There was a problem hiding this comment.
Spotless also has an opinion about this:
-················throw·new·IllegalArgumentException("Couldn't·find·the·widget·in·the·add-on·entry.·The·starting·code·fence·may·not·be·marked·as·```yaml");
+················throw·new·IllegalArgumentException(
+························"Couldn't·find·the·widget·in·the·add-on·entry.·The·starting·code·fence·may·not·be·marked·as·```yaml");Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing from marketplace gives an Error that is not very helpful.
Couldn’t find the widget in the add-on entry
The cause was missing ```yaml code fence when a normal code fence was used. This used to work in the past so a number of widgets are done this way and will not install. Suggest a more useful message to help guide widget devs.